Skip to content

Conversation

rikublock
Copy link
Contributor

Summary

schema.ts seems to be outdated due to changes between e444586 (5.4.3rc1) and current HEAD.

Note: Should double check to ensure the update was generated correctly.

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@rikublock rikublock marked this pull request as ready for review November 28, 2024 14:27
@github-actions github-actions bot added the frontend PRs that change frontend files label Nov 28, 2024
@psychedelicious
Copy link
Collaborator

We should add a CI action that fails when the frontend types don't match the server.

Until recently, such a CI action was not feasible, because type generation was non-deterministic. This was caused by unstable sorting of dict keys resulting in unstable sorting of the generated types file (the types were functionally the same, just the file itself was unstable).

That issue has since been resolved, and the output types file is 100% deterministic, so a CI action that checks the types is now feasible.

@psychedelicious psychedelicious enabled auto-merge (rebase) December 2, 2024 03:53
@psychedelicious psychedelicious force-pushed the riku/fix-typegen-schema branch from f422266 to 5e3d1c4 Compare December 2, 2024 03:54
@psychedelicious psychedelicious merged commit 3fbf6f2 into invoke-ai:main Dec 2, 2024
14 checks passed
@rikublock
Copy link
Contributor Author

We should add a CI action that fails when the frontend types don't match the server.

@psychedelicious I can potentially have a look at this. Is there a specific way you want this to be implemented?

I was thinking something like:

  • create a new github action typegen-checks.yml
  • run make frontend-typegen (needs both python and js env)
  • check that schema.ts has no diff

(It's already out of sync again due to #7393)

@psychedelicious
Copy link
Collaborator

@rikublock
Yep, that sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend PRs that change frontend files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants