fix(ui): call cancel instead of clear queue #7392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
force-pushed
the
riku/fix-cancel-current-button
branch
from
7ec3b1c to
2dc1757
Compare
psychedelicious
requested review from
psychedelicious,
blessedcoolant,
maryhipp and
hipsterusername
as code owners
psychedelicious
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Thanks! #7391 is merged and I rebased this to get the fix in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The cancel button in
<QueueActionsMenuButton />erroneously calls "clear queue" instead of "cancel queue item".Merge Plan
Creates a conflict without #7391 due to changes on subsequent lines. Will rebase once merged/rejected/closed.
Checklist
What's Newcopy (if doing a release after this PR)