Add the lint package #113
Open
Add the lint package #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables a larger set of lint checks than the one already enabled in analysis options
|
Thanks for creating the PR! My understanding is that when NNBD is released they're also going to provide automated tools to help migrate the code, do you think corrections for these errors/warnings will be included? |
|
It seems likely that implicit cast will be automatically converted to explicit casts. May be @stereotype441 and @MichaelRFairhurst know. Some of the remaining 2k warning can fixed relatively quick with IDE support (i.e. adding the But sadly there is not "Fix All" right now dart-lang/sdk#37228 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables a larger set of lint checks than the one which were already enabled by adding the
lintpackage.After enabling the new checks
flutter analyzereports317errors and1925warnings which will help to improve the source code.Most errors are caused by
implicit-casts: falsewhich requires manual casting fromdynamicto the proper type during assignment. This will become the default soon and is therefore recommended to be fixed.I recommend fixing the errors when merging this PR (nobody likes red squiggly lines everywhere) and then start fixing the warnings over time.