fix(ios): resolve native asset registration issues in New Architecture#843
Open
hallauman wants to merge 1 commit intoinvertase:mainfrom
Open
fix(ios): resolve native asset registration issues in New Architecture#843hallauman wants to merge 1 commit intoinvertase:mainfrom
hallauman wants to merge 1 commit intoinvertase:mainfrom
Conversation
This commit fixes an issue where native ad assets could not be found via their react tags when the New Architecture (Fabric) was enabled. - Added a recursive findViewByTag:inView: helper method to navigate the view hierarchy. - Updated registerAsset:reactTag: to use the new lookup logic in New Architecture. - The lookup now searches within both the _nativeAdView and the component itself.
|
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/react-native-google-mobile-ads~843 Documentation is deployed and generated using docs.page. |
|
이명규 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #843 +/- ##
==========================================
- Coverage 43.72% 36.02% -7.69%
==========================================
Files 30 36 +6
Lines 549 658 +109
Branches 151 167 +16
==========================================
- Hits 240 237 -3
- Misses 309 421 +112 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where native ad assets could not be found via their react tags when the New Architecture (Fabric) was enabled.
Description
Related issues
Release Summary
Checklist
and followed the process outlined there for submitting PRs.
AndroidiOSe2etests added or updated in__tests__e2e__jesttests added or updated in__tests__Test Plan
Think
react-native-google-mobile-adsis great? Please consider supporting the project with any of the below:Invertaseon Twitter