fix(app, sdks): adopt native SDK ios 12.17.0, android 34.16.0, js 12.17.0 - #9138
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
20f8ad4 to
2bbf12b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9138 +/- ##
==========================================
- Coverage 63.47% 63.45% -0.01%
==========================================
Files 389 389
Lines 30763 30763
Branches 4935 4870 -65
==========================================
- Hits 19524 19519 -5
+ Misses 10533 10488 -45
- Partials 706 756 +50
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Hey @mikehardy , hope you are doing well! Isn't this a breaking change since it requires ios 16.3 after version 12.15.0?
nevermind, xcode 16.3, not ios 16.3, :face_palm: |
|
I think, and hope, that since the break was for an Xcode that's no longer officially supported that it's not a break here - we're certainly not trying to unintentionally break people - we have enough breaking change going on after all 😅 Additionally I don't think anyone truly adopted RNFB v26.0.0 before we followed it quickly with 26.1.0 so even if we accidentally did something wrong there hopefully the affected population is effectively zero |
|
In order to prioritize work in this repository, closed issues and pull requests do not regularly receive attention. If the underlying issue or pull request still requires attention, opening a new issue with a reproduction |
Summary
scripts/update-firebase-sdk-versions.sh(docs, yarnrc age-gate preapprovals, lockfiles, Podfile.lock).@firebase/*packages (fixes yarn quarantine on@firebase/componentduring JS upgrades).Test plan
packages/app/package.jsonmatch release notes (JS/iOS 12.17.0, BOM 34.16.0)docs/index.mdx