fix: emit messaging_notification_opened only for default notification action on iOS.#8945
Open
mtjkln wants to merge 4 commits intoinvertase:mainfrom
Open
fix: emit messaging_notification_opened only for default notification action on iOS.#8945mtjkln wants to merge 4 commits intoinvertase:mainfrom
mtjkln wants to merge 4 commits intoinvertase:mainfrom
Conversation
…lt notification action Ensure messaging_notification_opened is emitted only when the UNNotificationDefaultActionIdentifier is triggered. This prevents onNotificationOpened from being invoked for custom notification actions.
|
@mtjkln is attempting to deploy a commit to the Invertase Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
🔥 Fix: emit messaging_notification_opened only for default notification action on iOS.
Summary
Ensure
messaging_notification_openedis emitted only when the default notification action is triggered on iOS.Previously the event could be emitted for all
UNNotificationResponseactions, including custom notification actions.This change restricts the event emission to
UNNotificationDefaultActionIdentifier, ensuringonNotificationOpenedAppis invoked only when the user taps the notification body.Why
When notifications include custom actions (e.g. Reply, Mark as Read), selecting those actions previously triggered
messaging_notification_opened.This caused
onNotificationOpenedAppto fire and often resulted in unintended navigation or redirection in apps that rely on the default notification tap behavior for routing.By emitting the event only for
UNNotificationDefaultActionIdentifier, custom actions no longer triggeronNotificationOpenedApp, aligning the behavior with expected iOS notification interaction patterns.Related issues
N/A
Release Summary
Fix iOS behavior where
messaging_notification_openedcould be emitted for custom notification actions. The event is now emitted only for the default notification tap.Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/**/e2ejesttests added or updated inpackages/**/__tests__Test Plan
onNotificationOpenedAppis triggered.onNotificationOpenedAppis not triggered.Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter