Skip to content

fix!: remove deprecated API from auth & crashlytics #8636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 4, 2025

Conversation

russellwheatley
Copy link
Member

Description

  • firestore settings host is marked as deprecated but all the documentation on web, android & iOS have it as being not deprecated. I suggest we remove the console.warning() for it.

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Jul 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 4, 2025 9:26am

@russellwheatley russellwheatley changed the title fix!: Remove deprecated api fix!: Remove deprecated api from auth & crashlytics Jul 31, 2025
@russellwheatley russellwheatley marked this pull request as ready for review July 31, 2025 12:33
@russellwheatley russellwheatley changed the title fix!: Remove deprecated api from auth & crashlytics fix!: remove deprecated API from auth & crashlytics Jul 31, 2025
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seem good - agreed if no deprecation mark upstream on firestore host, we shouldn't have it deprecated here since we are downstream / derivative

approving all the changes so far and pre-approving removing the host deprecation code

@mikehardy mikehardy added Workflow: Waiting for User Response Blocked waiting for user response. Workflow: Pending Merge Waiting on CI or similar labels Jul 31, 2025
@russellwheatley russellwheatley merged commit 213b939 into main Aug 4, 2025
17 of 20 checks passed
@russellwheatley russellwheatley deleted the remove-deprecated-api branch August 4, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Workflow: Pending Merge Waiting on CI or similar Workflow: Waiting for User Response Blocked waiting for user response.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants