Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(functions, ios): repair release mode crash in functions #8371

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mikehardy
Copy link
Collaborator

Description

This should be / will be a PR to fix a functions crash that reproduces in release mode on iOS

Currently this only has the small addition to our run scripts required to build / run e2e test in release mode, which shows the crash in the functions suite. Check the Test Plan section below for reproduction steps on this branch

Related issues

Release Summary

Ideally this will have a commit in here with a fix semantic release tag

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

With the commit on this PR you can run these and see the crash:

yarn test:ios:build-release
yarn test:ios:test-release

Think react-native-firebase is great? Please consider supporting the project with any of the below:

this immediately reproduces a functions crash
Copy link

vercel bot commented Feb 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 25, 2025 0:01am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Attention plugin: functions Firebase Cloud Functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔥 Functions crash in IOS Release Mode only
1 participant