Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): resolve type issue when migrating to v9 #8277

Merged
merged 5 commits into from
Feb 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/auth/lib/modular/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,12 @@
* limitations under the License.
*/

import { FirebaseApp } from '@firebase/app-types';
import { ReactNativeFirebase } from '@react-native-firebase/app';
import { FirebaseAuthTypes, CallbackOrObserver, AuthListenerCallback } from '../index';
import { firebase } from '..';

import Auth = FirebaseAuthTypes.Module;
import FirebaseApp = ReactNativeFirebase.FirebaseApp;

/**
* Returns the Auth instance associated with the provided FirebaseApp.
Expand Down
2 changes: 0 additions & 2 deletions packages/database/lib/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@

import { ReactNativeFirebase } from '@react-native-firebase/app';

export type FirebaseApp = ReactNativeFirebase.FirebaseApp;

/**
* Firebase Database package for React Native.
*
Expand Down
3 changes: 2 additions & 1 deletion packages/functions/lib/modular/index.d.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { FirebaseApp } from '@firebase/app';
import { ReactNativeFirebase } from '@react-native-firebase/app';
import { FirebaseFunctionsTypes } from '..';

import FirebaseApp = ReactNativeFirebase.FirebaseApp;
import Functions = FirebaseFunctionsTypes.Module;
import HttpsCallable = FirebaseFunctionsTypes.HttpsCallable;
import HttpsCallableOptions = FirebaseFunctionsTypes.HttpsCallableOptions;
Expand Down
3 changes: 2 additions & 1 deletion packages/messaging/lib/modular/index.d.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import { FirebaseMessagingTypes } from '..';
import { FirebaseApp } from '@firebase/app-types';
import { ReactNativeFirebase } from '@react-native-firebase/app';

import Messaging = FirebaseStorageTypes.Module;
import FirebaseApp = ReactNativeFirebase.FirebaseApp;

/**
* Returns a Messaging instance for the given app.
Expand Down
3 changes: 2 additions & 1 deletion packages/ml/lib/modular/index.d.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import { FirebaseApp } from '@firebase/app-types';
import { ReactNativeFirebase } from '@react-native-firebase/app';
import { FirebaseMLTypes } from '..';

type FirebaseML = FirebaseMLTypes.Module;
import FirebaseApp = ReactNativeFirebase.FirebaseApp;

/**
* Returns the existing default {@link FirebaseML} instance that is associated with the
Expand Down
3 changes: 2 additions & 1 deletion packages/perf/lib/modular/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* limitations under the License.
*
*/
import { FirebaseApp } from '@firebase/app-types';
import { ReactNativeFirebase } from '@react-native-firebase/app';
import { FirebasePerformanceTypes } from '..';

import Performance = FirebasePerformanceTypes.Module;
Expand All @@ -23,6 +23,7 @@ import Trace = FirebasePerformanceTypes.Module.Trace;
import HttpMethod = FirebasePerformanceTypes.HttpMethod;
import HttpMetric = FirebasePerformanceTypes.HttpMetric;
import ScreenTrace = FirebasePerformanceTypes.ScreenTrace;
import FirebaseApp = ReactNativeFirebase.FirebaseApp;

/**
* Returns a Performance instance for the given app.
Expand Down
3 changes: 2 additions & 1 deletion packages/remote-config/lib/modular/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* limitations under the License.
*
*/
import { FirebaseApp } from '@firebase/app-types';
import { ReactNativeFirebase } from '@react-native-firebase/app';
import { FirebaseRemoteConfigTypes } from '..';

import RemoteConfig = FirebaseRemoteConfigTypes.Module;
Expand All @@ -24,6 +24,7 @@ import ConfigDefaults = FirebaseRemoteConfigTypes.ConfigDefaults;
import ConfigSettings = FirebaseRemoteConfigTypes.ConfigSettings;
import LastFetchStatusType = FirebaseRemoteConfigTypes.LastFetchStatusType;
import RemoteConfigLogLevel = FirebaseRemoteConfigTypes.RemoteConfigLogLevel;
import FirebaseApp = ReactNativeFirebase.FirebaseApp;

/**
* Returns a RemoteConfig instance for the given app.
Expand Down
3 changes: 2 additions & 1 deletion packages/storage/lib/modular/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*
*/

import { FirebaseApp } from '@firebase/app-types';
import { ReactNativeFirebase } from '@react-native-firebase/app';
import { FirebaseStorageTypes } from '../index';

import Storage = FirebaseStorageTypes.Module;
Expand All @@ -27,6 +27,7 @@ import Task = FirebaseStorageTypes.Task;
import ListOptions = FirebaseStorageTypes.ListOptions;
import SettableMetadata = FirebaseStorageTypes.SettableMetadata;
import EmulatorMockTokenOptions = FirebaseStorageTypes.EmulatorMockTokenOptions;
import FirebaseApp = ReactNativeFirebase.FirebaseApp;

/**
* Returns the existing default {@link Storage} instance that is associated with the
Expand Down
Loading