Firestore Transactions #827
Conversation
…/react-native-firebase into firestore-transactions
…rebase into firestore-transactions
…rebase into firestore-transactions
Salakar
added
platform: android
platform: ios
platform: javascript
plugin: firestore
|
@Salakar, I see you use WIP on most PRs. We do that too but use this nice little integration: https://github.com/apps/wip. As long as 'WIP' is in the title you cannot merge the PR. Thought you might find it useful, cheers! |
|
@HofmannZ Interesting! Thanks for that :) |
| */ | ||
| export default class TransactionHandler { | ||
| _firestore: Firestore; | ||
| _transactionListener: Function; |
There was a problem hiding this comment.
Is there any reason to store this as we never unsubscribe from the listener?
There was a problem hiding this comment.
Hmm true good point, I just based it off the original stuff I did on RTDB transaction, guess we should remove storing on there as well tbh: https://github.com/invertase/react-native-firebase/blob/master/lib/modules/database/transaction.js#L24
There was a problem hiding this comment.
Yeah, may as well.
When I did the flow types for auth and firestore, I cleaned up a lot of this sort of stuff, but haven't got to database yet.
There was a problem hiding this comment.
Will remove on both, ta
| } | ||
|
|
||
| // reject the final promise and remove from native | ||
| if (updateFailed) { |
There was a problem hiding this comment.
At the moment, this only exits if the promise throws an exception, not if the update function isn't returning a promise. Is this correct?
There was a problem hiding this comment.
Exits when the update function throws an error (e.g. bad code) or it Promise rejects. Added this as a boolean flag instead of if (finalError) { } as it's possible to Promise.reject() with no value/exception which would fall through and not exit.
There was a problem hiding this comment.
Ok, was just checking I could only see the boolean being set to true in the try/catch
…/react-native-firebase into firestore-transactions
…/react-native-firebase into firestore-transactions
…er at the start of each cycle
…estore-transactions
…w uses [transactionId stringValue])
Adds firestore transaction support for both Android & iOS