Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: vertexAI package support #8236

Open
wants to merge 122 commits into
base: main
Choose a base branch
from
Open

feat: vertexAI package support #8236

wants to merge 122 commits into from

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Jan 17, 2025

Description

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 8:45am

@russellwheatley russellwheatley changed the title init feat: vertexAI package support Jan 17, 2025
@santitopo
Copy link

Hey guys! Appreciate your effort to enable vertex AI on React Native!

Quick question, are you planning to use the native android/ios libs for vertex, or is this just leveraging the web js lib? I'm not seeing any native files in the PR's diff

Thanks!

@mikehardy
Copy link
Collaborator

Hey there @santitopo as you can see in the PR, it's currently implemented as a port of the web implementation from upstream, bent to match our local needs so that the auth and app-check integration (native) here are used, and with fetch polyfilled so that it can do streaming despite streams not being implemented in baseline react-native fetch.

@tomasabreu
Copy link

Hi, does anyone have an update on when this PR might be merged? Thanks!

@mikehardy
Copy link
Collaborator

mikehardy commented Feb 17, 2025

@tomasabreu going through internal review still but likely won't be long. Mostly commenting to say that as an open source repo it's always possible to clone the repo, checkout this branch, and run an npm pack in packages/vertexai to get an installable package and play with it. Normally I'd say you can use the patch-package patch set but since this package hasn't been published yet there's nothing to patch...

@russellwheatley
Copy link
Member Author

Co-author attribution for this work needs to be added.

When squashing + merging PR, we need to include the following in the commit body (i.e. text box that appears):

>
>
Co-authored-by: Daniel La Rocque <dlarocque@google.com>
Co-authored-by: hsubox76 <chholland@google.com>
Co-authored-by: Tanzim Hossain <tanzim@google.com>
Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Co-authored-by: DellaBitta <DellaBitta@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked: do-not-merge Do not merge this issue without approval by the person who labelled this issue as Do Not Merge Needs Attention
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature request: Support for VertexAi
10 participants