Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Documentation only changes. Update ios-setup.md #8187

Closed
wants to merge 2 commits into from

Conversation

faizan2301
Copy link

@faizan2301 faizan2301 commented Dec 12, 2024

docs: Documentation only changes

Checking the app's entitlements file to ensure the aps-environment key is set to production for the release build.

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • [ ✅] Yes
  • My change supports the following platforms;
    • Android
    • [ ✅] iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • [✅ ] No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Checking the app's entitlements file to ensure the aps-environment key is set to production for the release build.
Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 6:24am

@CLAassistant
Copy link

CLAassistant commented Dec 12, 2024

CLA assistant check
All committers have signed the CLA.

@faizan2301 faizan2301 changed the title Update ios-setup.md docs: Documentation only changes. Update ios-setup.md Dec 12, 2024
Checking the app's entitlements file to ensure the aps-environment key is set to production for the release build.
Copy link
Author

@faizan2301 faizan2301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the aps-environment setup for iOS in production because it was not found in the documentation.

@mikehardy
Copy link
Collaborator

It wasn't found in the documentation because Xcode is supposed to handle this for you in the build step
No one else has needed to do this, and I do not need to do this either. I don't think it is required for most people and I believe your setup must be very particular in some way that applies to no one else I've encountered before

I don't think the advice to change it is good advice for most people

Copy link

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Jan 14, 2025
@mikehardy mikehardy closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants