fix(auth, ios): demonstrate test integration of upstream fix 13772 #8054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikehardy
added
platform: ios
blocked: firebase-sdk
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This was never intended for merge - it was for demonstration only - and I will close it now |
mikehardy
added
resolution: fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not for merge
This is a demonstration of how to patch a source file integrated via cocoapods in a react-native context
It should handle these cases:
[cocoapods-patch](https://github.com/DoubleSymmetry/cocoapods-patch)but you have to install things, that is unwanted--forwardand the(command || true)construction in patch call means it will silently proceed without a non-zero exit code, even if patch is already applied)Doing something like this in your project may help you test-integrate the upstream fix to see if it stops the crashing for you
See related discussion at firebase/firebase-ios-sdk#13761