test(deps): adopt Xcode 15 / iOS 17 in CI #7357
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mikehardy
added
the
Workflow: Needs Review
mikehardy
force-pushed
the
@mikehardy/xcode-15
branch
from
fb34309 to
f529860
Compare
mikehardy
force-pushed
the
@mikehardy/xcode-15
branch
from
f529860 to
bf23593
Compare
mikehardy
force-pushed
the
@mikehardy/xcode-15
branch
from
bf23593 to
0b225fc
Compare
- update our device type / os definitions to be iOS 17.0 This is to match with the current new installation values you get when installing Xcode 15 - iOS 16.4 is not available by default and you have to install them manually (taking a lot of disk space...) to use it. You will still need to manually create an iPhone 14 device though - update CI xcode from xcode-current to 15
…emulators the list at https://github.com/actions/runner-images/blob/main/images/macos/macos-13-Readme.md#installed-simulators does not appear to be accurate as a test run is returning simulator not found on a tuple that should work
mikehardy
force-pushed
the
@mikehardy/xcode-15
branch
from
0b225fc to
0e8eb62
Compare
|
superceded by #7374 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is to match with the current new installation values you get when installing Xcode 15 - iPhone 14 / iOS 16.4 are not available by default and you have to install them manually if you want them
Note that this may not work, I'm not sure what Xcode is actually available in the current runner images, so this is a little speculative and the CI run log will need examination
Release Summary
conventional commit, won't trigger a release
Checklist
AndroidiOSe2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Tested locally and everything appears to work except some timing-related flakiness on remote-config onConfigUpdated that I also saw on the old Simulator - so I'm curious how it goes in CI
Nabeel also mentioned a compile issue that required a new build flag but I was not able to reproduce a need for this locally. Detailed as:
If it reproduces in CI I'll adopt that change in this PR
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter