feat(app, sdks)!: update underlying SDKs w/related forward porting #7157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is speculative and unique to a dev environment situation I have where the emulator is on a different machine and it is more convenient for me to forward the ports required if they are stable instead of ephemeral. I don't *think* this will affect anyone else negatively as we are not running multiple detox instances on the same machine that I know of, but this may be removed without discussion if it causes harm to anyone anytime
the modular tests include a v8 compatibility test section, which was otherwise duplicate of the main test file move the modular test file into the main test file's place
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
mikehardy
force-pushed
the
@mikehardy/dependency-updates
branch
from
0a76928 to
f30f1b7
Compare
mikehardy
force-pushed
the
@mikehardy/dependency-updates
branch
from
f30f1b7 to
e64811a
Compare
….5.0 BREAKING CHANGE: firebase-ios-sdk 10.8.0 and higher require Xcode 13.3+, which transitively requires macOS 12.0+. You must update your CI build environments to meet these minimums as well as your development environments - if you have older hardware that still works but cannot be upgraded normally, you may like: https://dortania.github.io/OpenCore-Legacy-Patcher/
mikehardy
force-pushed
the
@mikehardy/dependency-updates
branch
from
e64811a to
8990cea
Compare
Codecov Report
@@ Coverage Diff @@
## main #7157 +/- ##
============================================
+ Coverage 54.00% 54.01% +0.01%
Complexity 734 734
============================================
Files 230 230
Lines 11503 11501 -2
Branches 1854 1853 -1
============================================
Hits 6211 6211
+ Misses 4949 4947 -2
Partials 343 343 |
…moved Note that forcing server retrieval of firestore named queries against loaded firestore data bundles may fail on android with this SDK version. It appears results will always come from the local cache. BREAKING CHANGE: the "safetyNet" provider for App Check has been removed from the underlying firebase-android-sdk and we have removed it here. You should upgrade to the "playIntegrity" provider for App Check
BREAKING CHANGE: this version of the underlying firebase-ios-sdk has a minimum Xcode requirement of 14.1 which transitively implies a macOS minimum version of 12.5
mikehardy
changed the title
|
android just passed on the last commit - it's really slow so I will not wait for it again but the final commit I just pushed is iOS-only so that has no impact Need to peel an issue off to investigate the source behavior for firebase named queries on collections cached locally from loaded bundles, that behavior has changed in android and ios SDKs since prior versions |
- pod install can take as much as 16 minutes now - compile + pod install on new SDKs can take more than 60 minutes combined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains a number of independent commits but all of them bring the underlying software up to date - review should be done commit-by-commit
This is a breaking change in that it requires higher minimum versions of transitive dependencies - specifically:
Each of these steps implies sets of older Apple hardware that are no longer officially supported, however if you are affected by this and your old hardware is still otherwise functional, you may enjoy https://dortania.github.io/OpenCore-Legacy-Patcher/
Related issues
Multiple issues resolved in the upstream firebase-ios-sdk / firebase-android-sdk repositories, and adopting their newer versions resolves the issues transitively for consumers of react-native-firebase
Release Summary
Multiple independent commits prepared for a rebase+merge, each one following conventional commit conventions
Checklist
AndroidiOSe2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter