Skip to content

feat(app, config): implement setLogLevel API #5606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2021

Conversation

mikehardy
Copy link
Collaborator

Description

Now you may set the firebase log level from firebase.json or via JS
This is very interesting in some cases, like when you need the AppCheck debug token
on iOS, to test AppCheck SafetyNet during development

Related issues

#5346 - mentioned release build error #5346 (reply in thread)
#5581

Release Summary

conventional commits - rebase merge...

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Now you may set the firebase log level from firebase.json or via JS
This is very interesting in some cases, like when you need the AppCheck debug token
on iOS, to test AppCheck SafetyNet during development
The debug provider is only used if the app is debuggable, and still requires
a token passed through somehow, so this doesn't increase security attack surface
area, but it does mean that release builds will have the symbol available which is
important
@vercel
Copy link

vercel bot commented Aug 17, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

react-native-firebase – ./

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/8Y48kzQLT1V5Pero3aC5FerHvEqz
✅ Preview: https://react-native-firebase-git-mikehardy-app-setloglevel-invertase.vercel.app

react-native-firebase-next – ./website_modular

🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/9YgaUbBXRmepsR9APcwWALp31Jvj
✅ Preview: Canceled

@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #5606 (120c090) into master (fe0bd01) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

❗ Current head 120c090 differs from pull request most recent head cc40999. Consider uploading reports for the commit cc40999 to get more accurate results

@@             Coverage Diff              @@
##             master    #5606      +/-   ##
============================================
- Coverage     53.70%   53.65%   -0.04%     
  Complexity      614      614              
============================================
  Files           202      202              
  Lines          9938     9943       +5     
  Branches       1528     1530       +2     
============================================
- Hits           5336     5334       -2     
- Misses         4332     4337       +5     
- Partials        270      272       +2     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant