-
Notifications
You must be signed in to change notification settings - Fork 2.3k
feat(analytics, ATT): allow use of AnalyticsWithoutAdIdSupport pod #5224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/invertase/react-native-firebase/4qUcp1rrAAoWXromot4tPd5FzwrV |
Codecov Report
@@ Coverage Diff @@
## master #5224 +/- ##
===========================================
- Coverage 88.86% 36.57% -52.29%
===========================================
Files 109 51 -58
Lines 3743 1518 -2225
Branches 360 360
===========================================
- Hits 3326 555 -2771
- Misses 370 733 +363
- Partials 47 230 +183 |
Ruby code looks ok to me so not sure why it's not picking it up. Also I think it'd be worth having this mentioned in the analytics documentation somewhere |
I will definitely put it in the docs - once it works :-) |
242c7c2
to
1eb3200
Compare
Tested and all appears to work today as I took this up again, so I think it's ready to go technically. |
1eb3200
to
11890c0
Compare
- not compatible with AdMob, so put a warning in there - requires firebase-ios-sdk 7.11.0 but desire non-breaking, fail on install if req not met - add messaging during install to make new option more developer discoverable
11890c0
to
ebc7f20
Compare
Last change was moving the entire documentation block to a top-level header (instead of inside the firebase.json block as a sub-head), everything else was green -> merging |
Description
Allow use of new Analytics subspec that gets you Analytics without the Ad Id usage (thus no need for Apple App Transparency Tracking)
Related issues
Discussion here #5223
Release Summary
2 conventional commits, can be rebase merged
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter