-
Notifications
You must be signed in to change notification settings - Fork 2.3k
feat(auth, multi-tenant): add multi-tenant (tenantID) support #5019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/invertase/react-native-firebase/FBEZQKXga5YfFB4izy4a4ZszyVvY |
Codecov Report
@@ Coverage Diff @@
## master #5019 +/- ##
==========================================
- Coverage 89.09% 89.09% -0.00%
==========================================
Files 109 109
Lines 3721 3728 +7
Branches 348 350 +2
==========================================
+ Hits 3315 3321 +6
Misses 365 365
- Partials 41 42 +1 |
@mikehardy here is the new PR with my correct email, I will sign CLA here. Thanks very much for reviewing the code. |
Awesome thanks for this. |
Thank you! We still have some underlying CI issues which are very new - just last couple days - I have hopes of triaging those so this is fully green but there should be nothing wrong with this PR as it is, I'm planning on merging it - cheers @xianlinbox |
without this, the xcodebuild commands could fail and you would still get a clean exit code, so CI (for example) would pass even though the iOS build failed
this exposed most of the errors fixed in prior commits, and allows you to see that setTenantId is working, but cannot be used against the emulator and we have no valid tenant id in our test project so it is unknown if this is truly working
0603da2
to
22fa36d
Compare
There was an iOS compile error inadvertently hidden by the way we were calling xcodebuild I just added these changes and pushed to your branch:
If it passes CI I think it will be good to go |
This is out as of v11.1.0 - please test and if there's anything wrong let us know - cheers! |
Do we need to manually set the tenantId or is it auto-populated when a user signs in? |
Description
When I working on the firebase auth, I found I can't set tenant id which is quite critical for working with Google Identity platform. In the repository discussion channel. there are 2 questions related with this also.
Then I checked the Firebase iOS SDK, which actually provided tenantId for user to set it. So I created this PR to open this capability to React native Lib users.
Related issues
No
Release Summary
Support set tenant it in Firebase auth module.
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
yarn tests:jest
Test Suites: 8 passed, 8 total
Tests: 1 skipped, 95 passed, 96 total
Snapshots: 0 total
Time: 20.6 s
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter