Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@russell/storage upload task snapshot #3330

Closed
wants to merge 10 commits into from

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Mar 21, 2020

fixes #3250

I tried using the promiseDefer method for the then getter property in StorageTask, but (as far as I I've tried), it doesn't work for our purposes.

@codecov
Copy link

codecov bot commented Mar 21, 2020

Codecov Report

Merging #3330 into master will increase coverage by 3.62%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3330      +/-   ##
==========================================
+ Coverage   81.55%   85.17%   +3.62%     
==========================================
  Files         108      108              
  Lines        3409     3425      +16     
==========================================
+ Hits         2780     2917     +137     
+ Misses        629      508     -121

@russellwheatley russellwheatley marked this pull request as ready for review March 25, 2020 13:27
@russellwheatley russellwheatley changed the base branch from next to master March 25, 2020 13:28
@Salakar
Copy link
Contributor

Salakar commented Mar 25, 2020

Linting failure on CI;

image

@Salakar
Copy link
Contributor

Salakar commented Mar 25, 2020

Also this has all the commits from next branch attached to it, you'll have to manually apply the changes to a new local branch based off of master I guess

@Salakar Salakar added the blocked: do-not-merge Do not merge this issue without approval by the person who labelled this issue as Do Not Merge label Mar 25, 2020
@russellwheatley
Copy link
Member Author

Yeah, you're right. I'll create another branch then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked: do-not-merge Do not merge this issue without approval by the person who labelled this issue as Do Not Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storage.ref(path_string).put(blob) returns promise other than task
2 participants