-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@russell/storage upload task snapshot #3330
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3330 +/- ##
==========================================
+ Coverage 81.55% 85.17% +3.62%
==========================================
Files 108 108
Lines 3409 3425 +16
==========================================
+ Hits 2780 2917 +137
+ Misses 629 508 -121 |
Also this has all the commits from |
Yeah, you're right. I'll create another branch then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blocked: do-not-merge
Do not merge this issue without approval by the person who labelled this issue as Do Not Merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3250
Switched
put
method to return aStorageTask
, not a promise. This is problem as it stops the user being able to useStorageTask
functionality.Updates storage
Task
so it has asnapshot
property available as per the web spec: https://firebase.google.com/docs/reference/js/firebase.storage.UploadTask#snapshotValue is initially set to
null
which is different to the web spec.I tried using the
promiseDefer
method for the then getter property inStorageTask
, but (as far as I I've tried), it doesn't work for our purposes.