feat(firestore): Support array-contains, array-contains-any & in filters

[Salakar]

Summary

Introduce support for newly released array-contains, array-contains-any & in query filters.

Blog: https://firebase.googleblog.com/2019/11/cloud-firestore-now-supports-in-queries.html

Closes #2842.

Checklist

• Supports Android
• Supports iOS
• e2e tests added or updated in packages/**/e2e
• Flow types updated
• Typescript types updated

---

Think react-native-firebase is great? Please consider supporting the project with any of the below:

• 👉 Donate via Open Collective
• 👉 Follow React Native Firebase and Invertase on Twitter
• 👉 Star this repo on GitHub ⭐️
• 👉 Contribute; see our contributing guide

[codecov]

Codecov Report

Merging #2868 into master will decrease coverage by 3.13%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2868      +/-   ##
==========================================
- Coverage   88.71%   85.58%   -3.12%     
==========================================
  Files         111      111              
  Lines        3444     3453       +9     
==========================================
- Hits         3055     2955     -100     
- Misses        389      498     +109

[Salakar]

Looks like the updated BoM is causing Vision tests to fail, might just be the tests are too specific though on checking the returned results.

[mikehardy]

Looks like the updated BoM is causing Vision tests to fail, might just be the tests are too specific though on checking the returned results.

It appears that while the iOS SDK appears to move along as a version-locked monorepo, if you look closely at the underlying version numbers the MLKit for instance is still alpha, so has breaking changes. In camo inside the larger SDK SemVer. I suppose the Android BoM works the same?

firebase/firebase-ios-sdk#3929 (comment)

No idea how to handle that

[Salakar]

@mikehardy I suppose the Android BoM works the same?

Aye correct. We'll just have to go fixing internal breaking changes in the code base before release, normally isn't too bad.

[meftunca]

How long do we have to wait for the release

[mikehardy]

Looks good - that's a lot of noise for the same BoM/Pod version spread out everywhere. Tough trade-off on install step facility vs the repetition - would be great if that was a variable or something though. Next thing you know the build will have 5 phases though I'm sure

[mikehardy]

@meftunca I'm sure it would be great if someone could test it, please do so and report back.

Here I provide a version of the PR you can apply using patch-package (which I swear by, excellent tool) -
@react-native-firebase+firestore+6.0.4.patch.gz

Just install patch-package per instructions (very quick+easy) and unzip that patch into the patches directory. It's a text file, you may visually confirm it contains the functional changes here.

You will need to override the underlying android and ios google SDK versions to do this. I demonstrate the 2 changes you need in your project here to specify the versions that will work: https://github.com/mikehardy/rnfbdemo/blob/master/make-demo-v6.sh#L28

In a few minutes you should have the PR in your project and hearing it works would be very helpful.

@Salakar I haven't figured out how to do patch-package effectively in monorepos yet. The ideal flow is "change yarn dependency in work project from regular version to git, optionally run a local build inside node_modules (typescript etc), run patch-package to generate a diff". In monorepos it's "clone repo, pull branch, run build, copy altered files into node_modules, run patch_package" which is really heavy. I haven't seen anything recommended online on how to solve it other than "gitpkg" but maybe you have an idea. Either way, I'm playing with v6 now 👀

[mikehardy]

removing this file causes conflicts on rebase to master but it's just a git add tests/ios/Podfile.lock fix.

[meftunca]

@mikehardy I'm sorry to see you late. You can rest assured that I'll send you feedback after I review it.

[meftunca]

@meftunca I'm sure it would be great if someone could test it, please do so and report back.

Here I provide a version of the PR you can apply using patch-package (which I swear by, excellent tool) -
@react-native-firebase+firestore+6.0.4.patch.gz

Just install patch-package per instructions (very quick+easy) and unzip that patch into the patches directory. It's a text file, you may visually confirm it contains the functional changes here.

You will need to override the underlying android and ios google SDK versions to do this. I demonstrate the 2 changes you need in your project here to specify the versions that will work: https://github.com/mikehardy/rnfbdemo/blob/master/make-demo-v6.sh#L28

In a few minutes you should have the PR in your project and hearing it works would be very helpful.

You can be sure that it works smoothly :)

I've been waiting for this property for a week. I couldn't write a proper description. I have currently tried it on android and has no problems with testing.

[mikehardy]

Fantastic! Thanks for testing it in the real world, that really helps @meftunca