Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript] Update storage typings #1346

Merged
merged 1 commit into from
Sep 11, 2018
Merged

[typescript] Update storage typings #1346

merged 1 commit into from
Sep 11, 2018

Conversation

squirly
Copy link
Contributor

@squirly squirly commented Jul 26, 2018

This cleans up the storage typescript typings by adding and removing methods, including documentation, and consolidating types.

@Salakar Salakar added this to the v5.0.0 Release milestone Aug 2, 2018
@Salakar Salakar requested review from Ehesp and Salakar August 2, 2018 12:22
@Salakar Salakar added plugin: storage Firebase Cloud Storage tools: typings TypeScript / Flow labels Aug 2, 2018
@Salakar
Copy link
Contributor

Salakar commented Aug 2, 2018

@squirly thanks for putting this together, we'll look at getting this in for v5 👍


Loving react-native-firebase and the support we provide? Please consider supporting us with any of the below:

@Salakar Salakar added the Workflow: Needs Review Pending feedback or review from a maintainer. label Aug 2, 2018
@Salakar
Copy link
Contributor

Salakar commented Aug 9, 2018

@squirly any chance you can rebase against master and fix the merge conflicts?

Thanks

@Salakar Salakar added Workflow: Waiting for User Response Blocked waiting for user response. Type: Stale Issue has become stale - automatically added by Stale bot and removed Workflow: Needs Review Pending feedback or review from a maintainer. labels Sep 10, 2018
@stale stale bot removed the Type: Stale Issue has become stale - automatically added by Stale bot label Sep 10, 2018
@Salakar Salakar assigned squirly and unassigned Ehesp and Salakar Sep 10, 2018
@CLAassistant
Copy link

CLAassistant commented Sep 10, 2018

CLA assistant check
All committers have signed the CLA.

@Salakar
Copy link
Contributor

Salakar commented Sep 11, 2018

@squirly thanks for updating. The analyse workflow on CI is passing (validates types) so I'm happy to merge this. Thanks again!

@Salakar Salakar merged commit 1e80ad3 into invertase:master Sep 11, 2018
@Salakar Salakar removed request for Ehesp and Salakar September 11, 2018 09:55
@squirly squirly deleted the storage-typings branch September 11, 2018 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: storage Firebase Cloud Storage tools: typings TypeScript / Flow Workflow: Waiting for User Response Blocked waiting for user response.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants