[🐛] RN@0.74 support?

[birdofpreyru]

Has anybody tested the library with the latest RN@0.74? I've just rapidly tried to upgrade my existing app, which depends on react-native-firebase from RN@0.73.6 to RN@0.74.1, and after the upgrade on Android (New Architecture) it tells

No Firebase App '[DEFAULT]' has been created - call firebase.initializeApp()

(which, I believe is supposed to happen automatically, thus I assume it fails to initialize for RN@0.74).

Also, what is the status of the new architecture support? With RN@0.73 the library works for me in an app using the new architecture on Android; but if I am not missing anything, it does not work alongside the new arch on iOS. The new arch has been around for a while now, and it is supported by most popular RN libraries... this one not supporting it is quite a bummer.

[birdofpreyru]

Ok, I found not yet merged PR #7688, which is related to the init failure.

[harisbaig100]

i tried applying the patch from this PR #7688 but still the error persists

[birdofpreyru]

@harisbaig100 that is a mediocre patch 🤣 Hold on, I have a working patch at hands, just need a bit more time to clean it up before sharing.

[harisbaig100]

Sure, please do share it, i'm waiting for that, my target platform is ios not android

[birdofpreyru]

Here you go:

diff --git a/node_modules/@react-native-firebase/app/lib/internal/registry/nativeModule.js b/node_modules/@react-native-firebase/app/lib/internal/registry/nativeModule.js
index 03f001c..23d467d 100644
--- a/node_modules/@react-native-firebase/app/lib/internal/registry/nativeModule.js
+++ b/node_modules/@react-native-firebase/app/lib/internal/registry/nativeModule.js
@@ -65,7 +65,7 @@ function nativeModuleWrapped(namespace, NativeModule, argToPrepend) {
     return NativeModule;
   }
 
-  const properties = Object.keys(NativeModule);
+  const properties = Object.keys(Object.getPrototypeOf(NativeModule));
 
   for (let i = 0, len = properties.length; i < len; i++) {
     const property = properties[i];

[harisbaig100]

now it says this error

[TypeError: nativeModule.getConstants is not a function. (In 'nativeModule.getConstants()', 'nativeModule.getConstants' is undefined)]

can you tell what version of the packages you are using, i'm using these :

"@react-native-firebase/app": "^15.3.0",
 "@react-native-firebase/crashlytics": "^15.3.0",
 "@react-native-firebase/messaging": "^15.3.0",

[harisbaig100]

updated the @react-native-firebase/app to 19.2 now the patch is applied let me check if it works

[harisbaig100]

on pod installation now this issue appears

[!] The following Swift pods cannot yet be integrated as static libraries:

The Swift pod `FirebaseCrashlytics` depends upon `FirebaseInstallations`, `GoogleDataTransport`, and `nanopb`, which do not define modules. To opt into those targets generating module maps (which is necessary to import them from Swift when building as static libraries), you may set `use_modular_headers!` globally in your Podfile, or specify `:modular_headers => true` for particular dependencies.

The Swift pod `FirebaseSessions` depends upon `FirebaseCoreExtension`, `FirebaseInstallations`, `GoogleDataTransport`, and `nanopb`, which do not define modules. To opt into those targets generating module maps (which is necessary to import them from Swift when building as static libraries), you may set `use_modular_headers!` globally in your Podfile, or specify `:modular_headers => true` for particular dependencies.

[birdofpreyru]

I forgot to mention it here, so far I only tested it for Android.

[harisbaig100]

okay ... trying to fix it for ios.

[hamdij0maa]

android is not loading it's an instant crash ...

[birdofpreyru]

Well, if you just bumped library major version from v15 to v19 chances are it is crashing for unrelated reason, because something had to change with the setup in-between 🤷‍♂️

[harisbaig100]

The error is still the same after fixing all the issues

[Error: No Firebase App '[DEFAULT]' has been created - call firebase.initializeApp()]