-
Notifications
You must be signed in to change notification settings - Fork 226
feat: Add support for specifying an IntelliJ module name prefix #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for specifying an IntelliJ module name prefix #349
Conversation
Also, I didn't update the current |
Looks like I missed a couple things here. Updates to follow in the next day or few. |
Thanks for this contribution! Looks great, aside from the analyzer errors (just some style issue) and formatting.
I think it's fine to leave it as is for now. |
Thanks blaugold 👍 For transparency, in addition to the style cleanup, I missed tracing the "melos_" prefix all the way down the stack, and it looks like it exists in hard-coded form beyond the areas I've addressed thus far, e.g., melos/packages/melos/lib/src/common/intellij_project.dart Lines 82 to 84 in 70448be
|
05aa290
to
16bbc2a
Compare
Hey @ryanhanks, I've rebased the PR and added the use of |
Hey @blaugold I pulled it down and gave it a run this morning, looks good to me! I must say, on my repo of 26 projects, it was v nice to open IntelliJ and see the results of this work :) Thanks for cleaning this up! Feel free to merge whenever you're ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Description
This change came about as a result of discussion around the 'melos_' string that is prepended to IntelliJ project module names, and the desire for that prefix to be blank.
The IntelliJ configuration parser currently assumes a single boolean value, so the parser has been updated to now support a map with which to specify intelliJ config.
The default value of enabled can now be overrode via an
enabled
key in the intellij map, and the parser continues support the current configuration approach, whereby theintellij
key is set to a boolean value:This map now allows for the specification of an alternative project module name prefix:
Type of Change
feat
-- New feature (non-breaking change which adds functionality)docs
-- DocumentationNotes