Skip to content

Conversation

@konvergence
Copy link

Fix for cookie ending with semicolon

@konvergence konvergence requested a review from a team as a code owner September 10, 2024 09:43
@MedAzizKhayati
Copy link

Thank you @konvergence for your hard work, I came here from this issue at FusionAuth, I am also facing the same problem, in my case I have no control over the provider so I cannot make them remove the semicolon from the Cookie and indeed this is the only solution I see.

A call to accept this MR.

@robotdan
Copy link
Member

robotdan commented Jul 10, 2025

Thanks @konvergence and @MedAzizKhayati !!

I expanded this PR a bit to pick up some other fixes and improvements for parsing cookies. I kept your test in my PR. Appreciate the PR!!

@robotdan
Copy link
Member

Closing, since #14 will fix this, and some other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants