-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement rollup & .d.ts generator #1372
base: master
Are you sure you want to change the base?
Conversation
Apparently, it's not as easy as I'd hoped, there's a bit more work to do on the testing side. 😅 |
"types": ["mocha", "reflect-metadata"], | ||
"moduleResolution": "node", | ||
"sourceMap": true, | ||
"jsx": "react", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need this ?
@@ -0,0 +1,3 @@ | |||
(async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clean-dist
and remove-dist
could be done using rm -rf dist/
i assume
no need to import packages for that.
} | ||
}, | ||
treeshake: { | ||
moduleSideEffects: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this not be true
?
"sinon": "9.2.4", | ||
"ts-node": "9.1.1", | ||
"tsify": "5.0.2", | ||
"tslint": "6.1.3", | ||
"typescript": "4.2.4", | ||
"updates": "12.0.2" | ||
}, | ||
"prettier": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's up with prettier here ?
Description
This PR implements rollup bundling and
.d.ts
generator using @microsoft/api-extractor.Related Issue
#1371
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: