Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Target.isTagged to exclude optional #1310

Conversation

notaphplover
Copy link
Member

Description

A binding with optional decorator should not be considered tagged just for that fact.
This PR adds optional to the list of decorators to exclude in order to determine whether or not a binding is tagged.

Related Issue

#1190

Motivation and Context

This change allow to determine wheter or not a binding is tagged and avoid unexpected behavior such as the one described in the related issue.

How Has This Been Tested?

  • Tests has been added to cover the issue behavior

Types of changes

  • Updated docs / Refactor code / Added a tests case (non-breaking change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the changelog.

…her inversify tags to determine whether or not a target is tagged
@notaphplover notaphplover requested a review from a team April 16, 2021 09:27
Copy link
Member

@dcavanagh dcavanagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@notaphplover notaphplover merged commit 28d20cc into master Apr 16, 2021
@notaphplover notaphplover deleted the fix/issue-1190-when-target-is-default-with-optional-injection branch April 16, 2021 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants