-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix injection of optional properties #1308
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
bcf6232
fix: update getTargets to correclty get constructorTargets when a con…
notaphplover dde758c
chore: update ci with es6 ci test jobs
notaphplover 7590605
chore: add typescript config that targets es6
notaphplover 179d8ed
style: add missing line feed
notaphplover 89a859d
style: add missing line feed
notaphplover be38463
docs: update changelog
notaphplover 3b8a99c
refactor: move e6 tsconfig with the other ts config files
notaphplover e02a2fa
Merge branch 'master' of https://github.com/inversify/InversifyJS int…
notaphplover 3dfcb5d
refactor tests for es6
dcavanagh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,6 +38,7 @@ dts | |
lib | ||
temp | ||
es | ||
es6 | ||
amd | ||
|
||
type_definitions/inversify/*.js | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
{ | ||
"include": [ | ||
"./**/*.ts" | ||
], | ||
"extends": "../tsconfig.json", | ||
"compilerOptions": { | ||
"target": "es6", | ||
"outDir": "../es6" | ||
}, | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
import { expect } from "chai"; | ||
import { Container, inject, injectable, optional } from "../../src/inversify"; | ||
|
||
|
||
describe("Issue 928", () => { | ||
|
||
it('should inject the right instances', () => { | ||
|
||
let injectedA: unknown; | ||
let injectedB: unknown; | ||
let injectedC: unknown; | ||
|
||
// some dependencies | ||
@injectable() class DepA { a = 1 } | ||
@injectable() class DepB { b = 1 } | ||
@injectable() class DepC { c = 1 } | ||
|
||
@injectable() abstract class AbstractCls { | ||
constructor(@inject(DepA) a: DepA, @inject(DepB) @optional() b: DepB = {b: 0}) { | ||
injectedA = a; | ||
injectedB = b; | ||
} | ||
} | ||
|
||
@injectable() class Cls extends AbstractCls { | ||
constructor(@inject(DepC) c: DepC, @inject(DepB) @optional() b: DepB = { b: 0 }, @inject(DepA) a: DepA) { | ||
super(a, b); | ||
|
||
injectedC = c; | ||
} | ||
} | ||
|
||
const container = new Container(); | ||
[DepA, DepB, DepC, Cls].forEach(i => container.bind(i).toSelf().inSingletonScope()); | ||
|
||
container.get(Cls); | ||
|
||
expect(injectedA).to.deep.eq(new DepA()); | ||
expect(injectedB).to.deep.eq(new DepB()); | ||
expect(injectedC).to.deep.eq(new DepC()); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️