Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Ensure links are prepended with base URL on receipt #8367

Merged
merged 2 commits into from
Oct 26, 2024
Merged

[Bug] Ensure links are prepended with base URL on receipt #8367

merged 2 commits into from
Oct 26, 2024

Conversation

SchrodingersGat
Copy link
Member

  • Fixes issue where "news" entries cannot be marked as read (as the "link" field is not valid)
  • Ensure that the base URL is prepended
  • Data migration for entries already in the database

@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed backport Apply this label to a PR to enable auto-backport action migration Data or schema migrations backport-to-0.16.x labels Oct 26, 2024
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Oct 26, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 26, 2024 •
edited
Loading

✅ Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit eb44b55
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/671c3cca8d01490008703c4f

@codecov Codecov
Copy link

codecov bot commented Oct 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 73.68421% with 5 lines in your changes missing coverage. Please review.

Project coverage is 84.42%. Comparing base (331692b) to head (eb44b55).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...nTree/common/migrations/0031_auto_20241026_0024.py 70.58% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8367      +/-   ##
==========================================
- Coverage   84.42%   84.42%   -0.01%     
==========================================
  Files        1166     1167       +1     
  Lines       53037    53055      +18     
  Branches     1946     1946              
==========================================
+ Hits        44779    44792      +13     
- Misses       7762     7767       +5     
  Partials      496      496
Flag Coverage Δ
backend 85.98% <73.68%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit 3253a4a into inventree:master Oct 26, 2024
26 checks passed
@SchrodingersGat SchrodingersGat deleted the news-fix branch October 26, 2024 01:40
github-actions bot pushed a commit that referenced this pull request Oct 26, 2024
@SchrodingersGat
[Bug] Ensure links are prepended with base URL on receipt (#8367)
7a365f3 
* Ensure links are prepended with base URL on receipt

* Bug fix

(cherry picked from commit 3253a4a)
@github-actions GitHub Actions
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 0.16.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@github-actions github-actions bot mentioned this pull request Oct 26, 2024
Merged
SchrodingersGat added a commit that referenced this pull request Oct 26, 2024
@github-actions @SchrodingersGat
[Bug] Ensure links are prepended with base URL on receipt (#8367) (#8370
343f63c 
)

* Ensure links are prepended with base URL on receipt

* Bug fix

(cherry picked from commit 3253a4a)

Co-authored-by: Oliver <oliver.henry.walters@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport Apply this label to a PR to enable auto-backport action backport-to-0.16.x bug Identifies a bug which needs to be addressed migration Data or schema migrations
Projects
None yet
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.
1 participant
@SchrodingersGat