-
-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SelectionList concept #8054
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8054 +/- ##
==========================================
+ Coverage 84.40% 84.42% +0.02%
==========================================
Files 1167 1171 +4
Lines 53057 53138 +81
Branches 1947 1951 +4
==========================================
+ Hits 44782 44861 +79
- Misses 7791 7794 +3
+ Partials 484 483 -1 ☔ View full report in Codecov by Sentry. |
@matmair looks like a couple of conflicts have snuck in here |
@matmair a couple of questions here:
|
It can be used to identify the source with a string (with a version, a uuid or something similar). Implementing or respecting that mechanism (or not) is left to plugin implementers.
I seem to have forgotten that, will add soon
We have a lot of sections in the Admin Center already so I thought it makes sense to keep it in the section that supports it. I can move it out if you want |
…add-selectionList
@matmair happy to review this again if you can fix the conflicts :) |
@matmair still some conflicts here when you are ready :) |
@matmair what's still to go on this one? |
This PR adds the concept of SelectionLists - a way to define reusable choices for parameters (optionally controllable by plugins).
This is helpful to load and sync a list of choices into multiple instances. The usage of SelectionLists could be extended in the future.
Screenshots
CUI
PUI
ToDo: