Use UV_SYSTEM_PYTHON to allow the system Python interpreter
#7317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of `VIRTUAL_ENV`
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
|
@zanieb thanks for getting in touch, and submitting a potential fix for us :) |
SchrodingersGat
added
CI
|
@zanieb looks like that has done the trick, many thanks :) |
|
Feel free to ping me if something breaks in the future. |
|
Thank you for the PR @zanieb! |
SchrodingersGat
pushed a commit
to SchrodingersGat/InvenTree
that referenced
this pull request
May 24, 2024
… of `VIRTUAL_ENV` (inventree#7317)
SchrodingersGat
added a commit
that referenced
this pull request
May 24, 2024
* Merge pull request from GHSA-2crp-q9pc-457j * ensure API login only works if mfa is not required * add migration to log out users * add migration to clear users * Use `UV_SYSTEM_PYTHON` to allow the system Python interpreter instead of `VIRTUAL_ENV` (#7317) * Fix docs links - pin to same branch * Handle exception on migration * Make migration non-atomic --------- Co-authored-by: Matthias Mair <code@mjmair.com> Co-authored-by: Zanie Blue <contact@zanie.dev>
This was referenced May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I noticed this repository linked in astral-sh/uv#3765 and see that you're having trouble with the breaking change we released. For some more context, you were using the
VIRTUAL_ENVvariable to point to a system installation which was a way to bypass our lack of system Python support. However, in the latest release we added stricter validation of virtual environments so ifVIRTUAL_ENVpoints to a system Python interpreter, we will ignore it. Of course, in CI you don't care about virtual environments and it's totally fine to mutate the system Python — for that reason we added--systemsupport a while ago.I saw in #7309 you tried to thread through a
--systemflag to opt-in to using the system interpreter. That's the right idea, but it's easy to miss a case — which will cause uv to fail as it did there. Instead, you can use theUV_SYSTEM_PYTHONflag to opt-in without threading the argument anywhere. I think this should solve your problems, if it doesn't I'll definitely look into it. I've added an integration test for this pattern to be sure we have extra coverage of it astral-sh/uv#3805. As a minor note, you could probably useUV_PYTHONwith the path to the interpreter as well as we'll allow you to explicitly select the system interpreter that way.In this pull request, I also add an upper bound to
uvso you shouldn't encounter any breaking changes unless you opt-in to a later version. Note, you could avoid installingpipin CI at all and use ourcurlinstaller with a pinned uv version e.g.curl -LsSf https://astral.sh/uv/0.2.2/install.sh | shbut then you can't use version ranges so 🤷♀️Of course, feel free to disregard this if you're not interested.