-
-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom user model #6418
Conversation
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
Does this also break related model fields in plugins that use the auth.user model? |
@wolflu05 yes, that is the main "breaking" thing |
This is targeted for 0.16.0 now and will be revisited once 0.15.0 is out. I think it is already advisable for plugin deps to either target Owners or the django.cong.settings auth model - a list of best practices is on my personal roadmap for 0.16.0 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6418 +/- ##
==========================================
- Coverage 83.96% 83.43% -0.54%
==========================================
Files 1057 1046 -11
Lines 46498 45806 -692
Branches 1360 1192 -168
==========================================
- Hits 39043 38217 -826
- Misses 7102 7335 +233
+ Partials 353 254 -99
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@matmair LGTM
|
Needs docs
I have tested that it works but I will try to add a CI test for that too |
@matmair do you want to target 0.16.x or bump to 0.17.x? |
@SchrodingersGat let's move this, I am focusing on getting user custom states in for 0.16.x |
Closing this in favour of an upcoming PR that adds a custom user model |
This PR refactors the usage of the build in User model to support custom auth models
[ ] unit tests to ensure custom user models work