Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to Dj 4.x #6173

Merged
merged 104 commits into from
Feb 6, 2024
Merged

Bump to Dj 4.x #6173

merged 104 commits into from
Feb 6, 2024

Conversation

matmair
Copy link
Member

@matmair matmair commented Jan 7, 2024

Close #2853
Follow up to #4584; Switch the code base to Django 4.2 (LTS) as 3.x is EOL in 2 months.

@SchrodingersGat
Copy link
Member

Only 1 error now

@matmair
Copy link
Member Author

matmair commented Feb 5, 2024

IMO the flag for the custom manger support is just not present on django-mptt. Adding it adds a bunch of migrations so I did not commit that.
If we get it to run in this state I think we should just merge and not care about it. The affected migrations are pretty old

@matmair matmair marked this pull request as ready for review February 5, 2024 20:26
@SchrodingersGat
Copy link
Member

The affected migrations are pretty old

We should look seriously into squashing migrations before a certain date, back a few major releases.

@matmair
Copy link
Member Author

matmair commented Feb 5, 2024

@SchrodingersGat I think we should do stuff like that with the 1.0. Maybe make a 0.99 release before and add a check that everything was updated to that and have some breaking changes in the transition to 1.0 like removing old migrations, moving config files out of the code source, move plugins dir etc.

@matmair matmair marked this pull request as draft February 5, 2024 23:38
@matmair
Copy link
Member Author

matmair commented Feb 6, 2024

FYI Debian 11 (Python 3.9, current min) is EOL 2024-08-15 so I think after that we could switch to Python 3.11 (default for Debian 12) or at least Python 3.10 (default for Ubuntu 22.04 which was released April 2022)

@SchrodingersGat
Copy link
Member

FYI Debian 11 (Python 3.9, current min) is EOL 2024-08-15 so I think after that we could switch to Python 3.11 (default for Debian 12) or at least Python 3.10 (default for Ubuntu 22.04 which was released April 2022)

@matmair happy with that. At some point we need to consider supporting python 3.12 - but that has only just been supported officially by django

@matmair
Copy link
Member Author

matmair commented Feb 6, 2024

@SchrodingersGat can you check the TZ addition in the notification age? Seems to work for me but want to be sure. Should be ready for review otherwise.
No idea why Deepsource is not working again - maybe we should switch to SonarCloud

@matmair matmair marked this pull request as ready for review February 6, 2024 01:43
@SchrodingersGat
Copy link
Member

@matmair LGTM - glad that we finally got this one worked out :)

@SchrodingersGat SchrodingersGat merged commit d36cf35 into inventree:master Feb 6, 2024
23 of 24 checks passed
@matmair
Copy link
Member Author

matmair commented Feb 6, 2024

I was getting nervous about the End of Life approaching; 0.14 is shaping up to be a good release.

@matmair matmair deleted the dj-4.x branch February 6, 2024 06:50
@SchrodingersGat
Copy link
Member

I've actually put a release data against 0.14.0 (end of Feb) so that we have something to work to :)

@SchrodingersGat SchrodingersGat added the breaking Indicates a major update or change which breaks compatibility label Feb 8, 2024
@SchrodingersGat
Copy link
Member

Note (#6453) that this PR requires some changes to the setup configuration if running behind a proxy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Indicates a major update or change which breaks compatibility dependency Relates to a project dependency enhancement This is an suggested enhancement or new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Django 4.x
2 participants