Cannot define hostname as base url

[lippoliv]

Please verify that this bug has NOT been raised before.

• I checked and didn't find a similar issue

Describe the bug*

I host InvenTree (currently) on a NAS in my local network. But I cannot define the hostname as a base url, probably because it has no TLD.

(Good news / workaround: I was able to workaround that using the tld "local", so I used "http://some-nas.local" and it worked)

Steps to Reproduce

1. Go to "Settings" section
2. Go to "Server settings"
3. Edit "Base url"
4. Enter "http://some-nas" (you can combine it with port or not, doesn't matter)
5. Save

Expected behaviour

Since it is a valid URL, I would expect it to save. But it doesn't. It Complains about invalid value.

Deployment Method

• Docker
• Bare metal

Version Information

0.12.7

Please verify if you can reproduce this bug on the demo site.

• I can reproduce this bug on the demo site.

Relevant log output

No response

[lippoliv]

@matmair here's the Bug which I mentioned in #5577 yesterday. Turns out, it's unrelated to port AND I found a workaround. So probably prio is not too high.

[SchrodingersGat]

Not sure if this is a "bug" here or not.. We would have to presumably change the way that URL validation is working under the hood, to allow specification of URLs with no TLD

[lippoliv]

Since it's a valid URL, I personally would classify it as a bug. On the other hand, this type of software most likely runs on companies who have internal servers with DNS configured, so most users will probably not hit this issue.

You can maybe "work arround" by mentioning that ".local" can be used as a TLD for local network hosting? Regarding the RFC it seems to be established world wide, so maybe this is a low-hanging-fruit to "fix" this?

[matmair]

A host without any domain comes with interesting security/usability implications. some-nas could be a (wired) gTLD, I would strongly recommend using a known TLD (including .local). Recommending .local is a double-edged sword. People should really be using proper DNS, self-announced hostnames/mDNS are pretty easily exploited.

[lippoliv]

I know that, and it's a fair point. But the argument is: It's still a valid base url and InvenTree is saying it's not.

I think either it is a accepted value by InvenTree or in this case InvenTree informs about "only hostname" base urls are permitted.

But right now I still think it's a bug (even if it's minor).

[SchrodingersGat]

I'd be on board with removing this restriction, it may require tweaking some of our underlying url validation code

[matmair]

We can modify the specific validator for this field but I would caution against allowing domain-less URLs in the general validator.