"Stock" item in toolbar/menus not visible when no permissions for "Stock Items"

[plaes]

Please verify that this bug has NOT been raised before.

• I checked and didn't find a similar issue

Describe the bug*

"Stock" toolbar is not visible with following group permissions:

Steps to Reproduce

1. Add a group with only view permissions for "Stock Locations"
2. Make sure that the "View" and all other permissions for "Stock Items" is dropped.
3. Observe that "Stock" is missing from main toolbar (and other locations) for users of this group

One can still manually browse the "{SITE}/web/stock/location/index/sublocations" URL, so in backend things seem to be ok.

Expected behaviour

"Stock" would be still visible.

Deployment Method

Docker

Version Information

1.1.11.

Try to reproduce on the demo site

I did not try to reproduce

Is the bug reproducible on the demo site?

Not reproducible

Relevant log output

[SchrodingersGat]

@plaes thanks for reporting

It looks like these major nav tabs check only one role, the "stock" role - so a "stock location" role would have no effect if the user does not have "stock" permissions.

InvenTree/src/frontend/src/defaults/links.tsx

Line 27 in 2c59c16

export function getNavTabs(user: UserStateProps): NavTab[] {

export function getNavTabs(user: UserStateProps): NavTab[] {
  const navTabs: NavTab[] = [
    {
      name: 'home',
      title: t`Dashboard`,
      icon: <IconDashboard />
    },
    {
      name: 'part',
      title: t`Parts`,
      icon: <IconBox />,
      role: UserRoles.part
    },
    {
      name: 'stock',
      title: t`Stock`,
      icon: <IconPackages />,
      role: UserRoles.stock
    },
    {
      name: 'manufacturing',
      title: t`Manufacturing`,
      icon: <IconBuildingFactory2 />,
      role: UserRoles.build
    },
    {
      name: 'purchasing',
      title: t`Purchasing`,
      icon: <IconShoppingCart />,
      role: UserRoles.purchase_order
    },
    {
      name: 'sales',
      title: t`Sales`,
      icon: <IconTruckDelivery />,
      role: UserRoles.sales_order
    }
  ];

This would require a fix to check either of the roles for this tab - and then similar fixes for other places that the issue occurs.

Would you like to tackle this?