Create DB connection string from its parts if available #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-moser
force-pushed
the
granular-connection-strings
branch
2 times, most recently
from
7dfb05d to
2468dfe
Compare
slint
reviewed
Mar 30, 2025
invenio_db/ext.py
Outdated
| params[config_name] = app.config.get(f"DB_{config_name.upper()}", None) | ||
|
|
||
| if all(params.values()): | ||
| uri = f"{params['protocol']}://{params['user']}:{params['password']}@{params['host']}:{params['port']}/{params['name']}" |
There was a problem hiding this comment.
nit: I felt a bit uneasy looking at this and came across https://docs.sqlalchemy.org/en/20/core/engines.html#creating-urls-programmatically which might also handle some validation :)
Not a blocker, so feel free to take as out of scope and shelve.
There was a problem hiding this comment.
i've updated the PR to use that function, feels better to not code connection strings by hand
it seems like the protocol is the only actually required parameter for that function, should we relax the if all(params.values()) check accordingly?
personally i'm slightly leaning towards leaving it as is; i don't think laxness here will buy us a lot, and being stricter makes the opt-in stronger.
max-moser
force-pushed
the
granular-connection-strings
branch
2 times, most recently
from
7b83acd to
c4db08d
Compare
Co-authored-by: Sam AL-Arbid <samaa2@kth.se>
max-moser
force-pushed
the
granular-connection-strings
branch
from
c4db08d to
fb92eed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is basically the DB part of inveniosoftware/invenio-config#57 but doesn't require the settings to be set via environment variables –
invenio.cfgis also fine for example.