Add find_intersections to comparisons test suite
#205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamed2
approved these changes
Oct 18, 2022
omus
force-pushed
the
cv/find-intersections-comparison-tests
branch
from
d928cda
to
bc08bbb
Compare
|
Rebasing to get the CI to pass |
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
=======================================
Coverage 84.31% 84.31%
=======================================
Files 12 12
Lines 848 848
=======================================
Hits 715 715
Misses 133 133 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing #203 I was concerned about the small amount of testing done on
find_intersections. This addition makes me more confident in that basic behaviours offind_intersectionsare working.