Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document LeftEndpoint and RightEndpoint #148

Merged
merged 3 commits into from
Feb 22, 2021
Merged

Document LeftEndpoint and RightEndpoint #148

merged 3 commits into from
Feb 22, 2021

Conversation

nicoleepp
Copy link
Contributor

Closes #28

@nicoleepp nicoleepp requested a review from omus as a code owner October 16, 2020 21:11
@nicoleepp nicoleepp mentioned this pull request Oct 16, 2020
Merged
@codecov
Copy link

codecov bot commented Oct 16, 2020 •
edited
Loading

Codecov Report

Merging #148 (e709a4e) into master (b08373f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #148   +/-   ##
=======================================
  Coverage   76.55%   76.55%           
=======================================
  Files          11       11           
  Lines         516      516           
=======================================
  Hits          395      395           
  Misses        121      121
Impacted Files Coverage Δ
src/endpoint.jl 94.59% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b08373f...e709a4e. Read the comment docs.

@nicoleepp
Copy link
Contributor Author

@omus should I close this?

@omus
Copy link
Collaborator

omus commented Jan 6, 2021

We probably should document this function. I'll try to make a decision on this soon.

@omus
Copy link
Collaborator

omus commented Feb 22, 2021

Sorry this took so long. I've made a couple of changes and things are good to go now. Will squash and merge once the CI completes

@omus omus merged commit 8474023 into master Feb 22, 2021
@omus omus deleted the ne/document-endpoints branch February 22, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omus omus omus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document LeftEndpoint and RightEndpoint
2 participants
@nicoleepp @omus