Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate legacy serialization structs #139

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Conversation

omus
Copy link
Collaborator

@omus omus commented Sep 1, 2020

Just cleaning up this serialization compatibility code. I'm a little more familiar with custom serialization now and this seemed to be a better approach.

@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #139 into master will increase coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
+ Coverage   74.23%   74.40%   +0.16%     
==========================================
  Files          10       10              
  Lines         458      461       +3     
==========================================
+ Hits          340      343       +3     
  Misses        118      118              
Impacted Files Coverage Δ
src/compat.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfa3ea8...6cb26d4. Read the comment docs.

@omus omus merged commit 4f760f6 into master Sep 1, 2020
@omus omus deleted the cv/serialization-refactor branch September 1, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants