Accommodate JuliaSyntax in tests #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
=======================================
Coverage 97.39% 97.39%
=======================================
Files 5 5
Lines 230 230
=======================================
Hits 224 224
Misses 6 6 |
JuliaSyntax generates more consistent syntax trees for obscure versions of long and short form anonymous function argument lists. For the cases which are different and lead to errors, adjust the tests to use explicit `Expr`s here so that we're testing ExprTools code rather than the Julia parser itself. * `function (x)::Integer; x end` is now parsed correctly * Use an explicit Expr for the old `(;) -> nothing` syntax
c42f
force-pushed
the
caf/juliasyntax-fixes
branch
from
8e05fb9
to
553c498
Compare
|
I don't think the remaining formatting suggestion is any good so I didn't fix it. (Can fix if people actually want to obey the formatter over all else) |
oxinabox
approved these changes
Jun 22, 2023
|
The coverage of parser behavour in our tests is kinda amazing. |
|
Absolutely! Apparently including a bunch of cases which were actually bugs in the reference parser :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JuliaSyntax generates more consistent syntax trees for obscure versions of long and short form anonymous function argument lists. For the cases which are different and lead to errors, adjust the tests to use explicit
Exprs here so that we're testing ExprTools code rather than the Julia parser itself.function (x)::Integer; x endis now parsed correctly(;) -> nothingsyntax