This repository was archived by the owner on Dec 8, 2020. It is now read-only.
PR to PR#21 #1
Merged
PR to PR#21 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rofinn
approved these changes
Oct 4, 2020
Member
rofinn
left a comment
rofinn
left a comment
There was a problem hiding this comment.
LGTM. Since this doesn't really change the existing functionality that I need I'm good with whatever you think works best for consistency within the package.
I feel like the nameouter is a bit noisier, but I agree that it make more sense within the context of the rest of the package. I didn't notice the other wrapdims function doing that.
I still feel like if I know what kind of array type I want for the keys then I should probably just pre-allocate the KeyedArray and call populate!... but again, since other wrapdims functions are doing this then I guess this approach is more consistent.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref mcabbott#21 (comment)