refactor: booking쪽도 로그인 요구하는 화면은 NeedLogin으로 이름 변경

inu-appcenter · Sep 28, 2021 · ae9cb01 · ae9cb01
1 parent 4298d0f
commit ae9cb01
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 13 deletions.
diff --git a/src/presentation/features/booking/BookingScreen.tsx b/src/presentation/features/booking/BookingScreen.tsx
@@ -21,7 +21,7 @@ import React from 'react';
 import History from './History';
 import Complete from './Complete';
 import {observer} from 'mobx-react';
-import Onboarding from './Onboarding';
+import NeedLogin from './NeedLogin';
 import OptionsList from './OptionsList';
 import useUserState from '../../hooks/useUserState';
 import OptionsDetail from './OptionsDetail';
@@ -33,7 +33,7 @@ import {createStackNavigator} from '@react-navigation/stack';
 import BookingInfoHeaderButton from './History/BookingInfoHeaderButton';
 
 export type BookingNavigationParams = {
-  BookingOnboarding: undefined;
+  BookingNeedLogin: undefined;
   BookingStudentLogin: undefined;
   BookingGuestLogin: undefined;
 
@@ -52,11 +52,11 @@ function BookingScreen() {
    * 로그인 유도하는 화면.
    * 전체화면으로 보여줄거라서 헤더는 숨김.
    */
-  const onboarding = (
+  const needLogin = (
     <Stack.Screen
       key="booking_onboarding"
-      name="BookingOnboarding"
-      component={Onboarding}
+      name="BookingNeedLogin"
+      component={NeedLogin}
       options={{headerShown: false}}
     />
   );
@@ -145,7 +145,7 @@ function BookingScreen() {
 
   return (
     <Stack.Navigator headerMode="screen" screenOptions={StackHeaderPresets.commonStackHeaderOptions}>
-      {isLoggedIn ? [history, list, detail, complete] : [onboarding, studentLogin, guestLogin]}
+      {isLoggedIn ? [history, list, detail, complete] : [needLogin, studentLogin, guestLogin]}
     </Stack.Navigator>
   );
 }

diff --git a/...ion/features/booking/Onboarding/index.tsx → ...tion/features/booking/NeedLogin/index.tsx b/...ion/features/booking/Onboarding/index.tsx → ...tion/features/booking/NeedLogin/index.tsx
@@ -29,10 +29,10 @@ import {StyleSheet, Text, View} from 'react-native';
 import {BookingNavigationParams} from '../BookingScreen';
 
 type Props = {
-  navigation: StackNavigationProp<BookingNavigationParams, 'BookingOnboarding'>;
+  navigation: StackNavigationProp<BookingNavigationParams, 'BookingNeedLogin'>;
 };
 
-function Onboarding({navigation}: Props) {
+function NeedLogin({navigation}: Props) {
   const {isTryingRememberedLogin} = useUserState();
 
   const goStudentLogin = () => navigation.navigate('BookingStudentLogin');
@@ -67,7 +67,7 @@ function Onboarding({navigation}: Props) {
   return isTryingRememberedLogin ? loadingView : onboardingContents;
 }
 
-export default observer(Onboarding);
+export default observer(NeedLogin);
 
 const styles = StyleSheet.create({
   container: {

diff --git a/src/presentation/features/membership/MembershipScreen.tsx b/src/presentation/features/membership/MembershipScreen.tsx
@@ -38,7 +38,7 @@ function MembershipScreen() {
 
   const Stack = createStackNavigator<MembershipNavigationParams>();
 
-  const needLoginScreen = (
+  const needLogin = (
     <Stack.Screen
       key="membership_need_login_screen"
       name="MembershipNeedLogin"
@@ -47,7 +47,7 @@ function MembershipScreen() {
     />
   );
 
-  const loginScreen = (
+  const studentLogin = (
     <Stack.Screen
       key="membership_student_login_screen"
       name="MembershipStudentLogin"
@@ -56,7 +56,7 @@ function MembershipScreen() {
     />
   );
 
-  const barcodeScreen = (
+  const barcode = (
     <Stack.Screen
       key="membership_barcode_screen"
       name="MembershipBarcode"
@@ -70,7 +70,7 @@ function MembershipScreen() {
 
   return (
     <Stack.Navigator headerMode="screen" screenOptions={StackHeaderPresets.commonStackHeaderOptions}>
-      {isLoggedInAsStudent ? [barcodeScreen] : [needLoginScreen, loginScreen]}
+      {isLoggedInAsStudent ? [barcode] : [needLogin, studentLogin]}
     </Stack.Navigator>
   );
 }