Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle themes with objects #48

Merged
merged 7 commits into from
Mar 5, 2021
Merged

Handle themes with objects #48

merged 7 commits into from
Mar 5, 2021

Conversation

hipstersmoothie
Copy link
Contributor

@hipstersmoothie hipstersmoothie commented Feb 25, 2021

What Changed

see title

Why

You might keep a lot of token values on a deeply nested object.

Todo:

  • Add tests
  • Add docs

Published PR with canary version: 2.5.0-canary.48.616

@hipstersmoothie hipstersmoothie added the minor Increment the minor version when merged label Feb 25, 2021
@codecov-io
Copy link

codecov-io commented Feb 25, 2021

Codecov Report

Merging #48 (6666f4c) into master (b00df52) will increase coverage by 0.24%.
The diff coverage is 84.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   89.24%   89.48%   +0.24%     
==========================================
  Files           5        5              
  Lines         316      333      +17     
  Branches       80       86       +6     
==========================================
+ Hits          282      298      +16     
- Misses         20       21       +1     
  Partials       14       14              
Impacted Files Coverage Δ
src/index.ts 83.78% <0.00%> (ø)
src/common/index.ts 77.77% <33.33%> (-0.98%) ⬇️
src/legacy/index.ts 96.34% <91.66%> (ø)
src/modern/index.ts 93.79% <97.22%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b00df52...6666f4c. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 2abb437 into master Mar 5, 2021
@hipstersmoothie hipstersmoothie deleted the error branch March 5, 2021 17:09
@hipstersmoothie
Copy link
Contributor Author

🚀 PR was released in v2.5.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants