Skip to content

Conversation

@abisalehalliprasan
Copy link
Contributor

Adding support for 401k use case. Changes added :

1.) setAuthorizeURLs helper function to pass custom auth URL's
2.) Payslip Enum added
3.) Utils modification to handle any custom discovery doc URL's passed as plain string
4.) version change to 1.2.4

Copy link

@nimisha84 nimisha84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure you add overload func to accept auth urls directly too in case discovery call fails for some reason. Other then that, looks good

@abisalehalliprasan
Copy link
Contributor Author

Make sure you add overload func to accept auth URLs directly too in case discovery call fails for some reason. Other then that, looks good

@nimisha84 : Created a new helper method setAuthorizeURLs to have the ability to pass in the custom authorization URLs as a dictionary.

@abisalehalliprasan abisalehalliprasan merged commit 6a40386 into master Aug 11, 2020
@nimisha84
Copy link

def get_authorization_url(self, scopes, state_token=None): I see this uses enum scopes to build the authorization url. Can you add an overload to accept the string scopes as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants