Skip to content

Conversation

ScorpionFiko
Copy link
Contributor

@ScorpionFiko ScorpionFiko commented Jun 20, 2025

makeApiCall has been enhanced so that it makes a call to Quickbooks when:

  • user provides the full prod or sandbox URL (backward compatibility)
  • user provides the relative endpoint URL (/v3/company/...). It automatically pre-pends the sandbox or production URLs based on the environment property. This makes a seamless transition between sandbox and production.

Test cases for the change have been added

Test cases for setAuthorizeURLs have been added to increase the test coverage to the required level

BEFORE
=============================== Coverage summary ===============================
Statements : 94.68% ( 731/772 )
Branches : 82.82% ( 164/198 )
Functions : 92.11% ( 187/203 )
Lines : 95.46% ( 716/750 )

AFTER
=============================== Coverage summary ===============================
Statements : 95.8% ( 799/834 )
Branches : 85.57% ( 178/208 )
Functions : 93.27% ( 208/223 )
Lines : 96.54% ( 782/810 )

Copy link
Collaborator

@rajeshgupta723 rajeshgupta723 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, these changes are approved to go.

@rajeshgupta723 rajeshgupta723 merged commit 36a61c1 into intuit:master Jun 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants