Skip to content

Migrate to Chart.JS #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Migrate to Chart.JS #384

wants to merge 14 commits into from

Conversation

kevin-mcgoldrick
Copy link
Collaborator

Utilize Chart.js because the next release of primefaces requires it

  • Replace primefaces chart model with Chart.JS
  • Consistency on jquery icon usage in buttons

Please make sure these check boxes are checked before submitting

  • ** Squashed Commits **
  • ** All Tests Passed ** - mvn clean test -P default

** PR review process **

  • Requires one +1 from a reviewer
  • Repository owners will merge your PR once it is approved.

@kevin-mcgoldrick kevin-mcgoldrick self-assigned this Mar 17, 2025
Zakaria-Kofiro
Zakaria-Kofiro approved these changes May 1, 2025
View reviewed changes
Copy link
Collaborator

@Zakaria-Kofiro Zakaria-Kofiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevin-mcgoldrick
Merge branch 'master' into Primefaces15
d373ae9 
* master:
  Replace Apache Commons Codec Base64 usage with JDK Base64 (#378)
  banner in primfaces:messages (#383)
  Return 202 when applicable (#390)
  Fix BouncyCastle Proxy Usage (#394)
  Reduce Login Logging
@kevin-mcgoldrick
Merge branch 'master' into Primefaces15
2c8c5d5 
* master:
  Jexl3 Updates (#396)
  Increment 1% more coverage (#397)
  Fix Jobs Not Being Updated To Complete After Completing Test (#387)
  Bump org.jruby:jruby from 9.4.6.0 to 9.4.12.1 (#395)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zakaria-Kofiro Zakaria-Kofiro Zakaria-Kofiro approved these changes

Assignees

@kevin-mcgoldrick kevin-mcgoldrick

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevin-mcgoldrick @Zakaria-Kofiro