Skip to content

Conversation

@BobbieGoede
Copy link
Member

Description

This fixes a regression, the include and exclude options were not always normalized which breaks paths using forward slashes. This PR now normalizes these path options inside resolveOptions, and further normalizes them from string | string[] | undefined to string[] | undefined which allows us to remove some repeated logic.

Possible covers #501, though it is unclear since the issue creator did not provide a reproduction project

Linked Issues

Additional context

@coderabbitai
Copy link

coderabbitai bot commented Sep 10, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/normalize-include-exclude-paths

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 10, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@intlify/bundle-utils@507
npm i https://pkg.pr.new/@intlify/unplugin-vue-i18n@507

commit: 151c202

@kazupon kazupon added bug Includes new features ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf labels Sep 10, 2025
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Good job!
LGTM!

@kazupon kazupon merged commit 23133aa into v11 Sep 10, 2025
19 checks passed
@kazupon kazupon deleted the fix/normalize-include-exclude-paths branch September 10, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Includes new features ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants