P2022-1506 Prepare landspace layout/view #40
Conversation
Creates landscape for: activity_details, activity_login, activity_reset_password, fragment_sign_in, fragment_sign_up. Removes repeating color. Changing the button padding to incompatible with the design. Padding of the size given in the design cut off a piece of the text for smaller phones. Adds highlighting edit text in login files.
|
|
There was a problem hiding this comment.
Everything works.
Interesting use of nested scroll view and collapsing toolbar in details activity but I doubt that the user would care for scrolling before accessing the description and play button. (Ideally the play button would be at the top, over the image, or even a trailer would start playing automatically.)
The esthetics could be discussed (button not taking up the entire width of the screen), and we could consider putting tablayout in line with the app logo to save space and avoid scrolling, but without official designs everything goes and this successfully makes landscape views functional.
No access to reset password screen, but that's unrelated.
|
I was also thinking about the changes you mentioned, but as you wrote, there is no design, so I tried to make it as similar to portrait mode as possible. We can arrange the details at the meeting. |
Creates landspace for: activity_details, activity_login, activity_reset_password, fragment_sign_in, fragment_sign_up.
Removes repeating color.
Changing the button padding to incompatible with the design. Padding of the size given in the design cut off a piece of the text for smaller phones.
Adds highlighting edit text in login files.