Feature/patro23 46 fluent validation #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszmuszynski
suggested changes
Mar 11, 2023
mateuszgiedzinski
requested changes
Mar 13, 2023
src/modules/example/application/Example/CreatingExample/CreateExampleValidator.cs
Outdated
Show resolved
Hide resolved
added 6 commits
March 15, 2023 15:05
- readonly fields in ExampleController - ValidateAsync() instead of Validate() - Serializing private fields in error response
- using IValidator<ClassName> approach
- created properties in ErrorResponse - removed code responsible for private fields serializing
- Throw AppException when valiadtion fail
mateuszmuszynski
suggested changes
Mar 16, 2023
- Removed ErrorResponse class - Passing list of validation errors straight to AppException constructor
mateuszmuszynski
approved these changes
Mar 18, 2023
mateuszgiedzinski
approved these changes
Mar 19, 2023
src/modules/example/application/Example/GettingExamples/GetExamplesValidator.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.