Skip to content

Commit ada484c

Browse files
committed
remove intent with many vertices injection
1 parent a2f45f0 commit ada484c

File tree

3 files changed

+0
-20648
lines changed

3 files changed

+0
-20648
lines changed

monitoring/uss_qualifier/scenarios/astm/utm/flight_intent_validation/flight_intent_validation.md

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ FlightIntentsResource that provides the following flight intents:
2121
- `invalid_activated_offnominal`: state mutation `Activated`
2222
- `invalid_too_far_away`: reference time mutation: reference time pulled back so that it is like the operational intent is attempted to be planned more than OiMaxPlanHorizon = 30 days ahead of time
2323
- `valid_conflict_tiny_overlap`: volumes mutation: has a volume that overlaps with `valid_op_intent` just above IntersectionMinimumPrecision = 1cm in a way that must result as a conflict
24-
- `invalid_too_many_vertices`: volumes mutation: has more than OiMaxVertices = 10000 vertices in total across its volumes
2524

2625
### tested_uss
2726
FlightPlannerResource that will be tested for its validation of operational intents.
@@ -49,22 +48,6 @@ The tested USS is requested to remove all flights from the area under test.
4948

5049

5150
## Attempt to plan invalid flight intents test case
52-
### Attempt to plan flight with too many vertices in its volumes test step
53-
The user flight intent that the test driver attempts to plan has too many vertices across its volumes, more than
54-
OiMaxVertices = 10000 vertices. As such, the planning attempt should be rejected.
55-
56-
TODO: add check that intent was not planned at DSS
57-
58-
#### Incorrectly planned check
59-
If the USS successfully plans the flight or otherwise fails to indicate a rejection, it means that it failed to validate
60-
the intent provided. Therefore, this check will fail if the USS indicates success in creating the flight from the user
61-
flight intent, per **[astm.f3548.v21.OPIN0020](../../../../requirements/astm/f3548/v21.md)**.
62-
63-
#### Failure check
64-
All flight intent data provided was complete and correct. It should have been processed successfully, allowing the USS
65-
to reject or accept the flight. If the USS indicates that the injection attempt failed, this check will fail per
66-
**[interuss.automated_testing.flight_planning.ExpectedBehavior](../../../../requirements/interuss/automated_testing/flight_planning.md)**.
67-
6851
### Attempt to plan flight intent too far ahead of time test step
6952
The user flight intent that the test driver attempts to plan has a reference time that is more than
7053
OiMaxPlanHorizon = 30 days ahead of time from the actual intent. As such, the planning attempt should be rejected.

monitoring/uss_qualifier/scenarios/astm/utm/flight_intent_validation/flight_intent_validation.py

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,6 @@ class FlightIntentValidation(TestScenario):
4444

4545
invalid_too_far_away: FlightIntent
4646

47-
invalid_too_many_vertices: FlightIntent
48-
4947
# TODO: add the following intents for next tests
5048
# valid_conflict_tiny_overlap: FlightIntent
5149

@@ -68,7 +66,6 @@ def __init__(
6866
self.valid_flight,
6967
self.valid_activated,
7068
self.invalid_too_far_away,
71-
self.invalid_too_many_vertices,
7269
self.invalid_accepted_offnominal,
7370
self.invalid_activated_offnominal,
7471
# TODO: add the following intents for next tests
@@ -77,7 +74,6 @@ def __init__(
7774
flight_intents["valid_flight"],
7875
flight_intents["valid_activated"],
7976
flight_intents["invalid_too_far_away"],
80-
flight_intents["invalid_too_many_vertices"],
8177
flight_intents["invalid_accepted_offnominal"],
8278
flight_intents["invalid_activated_offnominal"],
8379
# TODO: add the following intents for next tests
@@ -96,10 +92,6 @@ def __init__(
9692
self.invalid_too_far_away.request.operational_intent.state
9793
== OperationalIntentState.Accepted
9894
), "invalid_too_far_away must have state Accepted"
99-
assert (
100-
self.invalid_too_many_vertices.request.operational_intent.state
101-
== OperationalIntentState.Accepted
102-
), "invalid_too_many_vertices must have Accepted"
10395
assert (
10496
self.invalid_accepted_offnominal.request.operational_intent.state
10597
== OperationalIntentState.Accepted
@@ -119,19 +111,6 @@ def __init__(
119111
time_delta.days > OiMaxPlanHorizonDays
120112
), f"invalid_too_far_away must have start time more than {OiMaxPlanHorizonDays} days ahead of reference time, got {time_delta}"
121113

122-
nb_vertices = 0
123-
for volume in (
124-
self.invalid_too_many_vertices.request.operational_intent.volumes
125-
+ self.invalid_too_many_vertices.request.operational_intent.off_nominal_volumes
126-
):
127-
if volume.volume.has_field_with_value("outline_polygon"):
128-
nb_vertices += len(volume.volume.outline_polygon.vertices)
129-
if volume.volume.has_field_with_value("outline_circle"):
130-
nb_vertices += 1
131-
assert (
132-
nb_vertices > OiMaxVertices
133-
), f"invalid_too_many_vertices must have more than {OiMaxVertices} vertices across its volumes, found {nb_vertices}"
134-
135114
assert (
136115
len(
137116
self.invalid_accepted_offnominal.request.operational_intent.off_nominal_volumes
@@ -197,7 +176,6 @@ def _setup(self) -> bool:
197176
self.invalid_accepted_offnominal,
198177
self.invalid_activated_offnominal,
199178
self.invalid_too_far_away,
200-
self.invalid_too_many_vertices,
201179
# TODO: add the following intents for next tests
202180
# self.valid_conflict_tiny_overlap,
203181
],
@@ -207,17 +185,6 @@ def _setup(self) -> bool:
207185
return True
208186

209187
def _attempt_invalid(self):
210-
resp, _ = submit_flight_intent(
211-
self,
212-
"Attempt to plan flight with too many vertices in its volumes",
213-
"Incorrectly planned",
214-
{InjectFlightResult.Rejected},
215-
{InjectFlightResult.Failed: "Failure"},
216-
self.tested_uss,
217-
self.invalid_too_many_vertices.request,
218-
)
219-
# TODO: validate not planned
220-
221188
resp, _ = submit_flight_intent(
222189
self,
223190
"Attempt to plan flight intent too far ahead of time",

0 commit comments

Comments
 (0)