Skip to content

Fix deleting files on import #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

isc-etamarch
Copy link
Collaborator

Fixes #618

@isc-etamarch isc-etamarch linked an issue Nov 1, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.84%. Comparing base (bd650c4) to head (5b56a43).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #620      +/-   ##
==========================================
- Coverage   25.85%   25.84%   -0.01%     
==========================================
  Files          21       21              
  Lines        2796     2797       +1     
==========================================
  Hits          723      723              
- Misses       2073     2074       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@isc-pbarton isc-pbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't need a CHANGELOG entry because it fixes a bug on an unreleased version, but looks good otherwise.

@isc-tleavitt isc-tleavitt merged commit 3f4317a into main Nov 1, 2024
2 checks passed
@isc-tleavitt isc-tleavitt deleted the 618-deleting-non-existent-files-still-fails-on-import-all branch November 1, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting non-existent files still fails on import all
4 participants